Skip to content

Do not canonicalize the file names when getting absolute paths during nodenext resolution #50557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

sheetalkamat
Copy link
Member

Fixes #50544

@sheetalkamat sheetalkamat requested a review from amcasey August 30, 2022 23:25
@sheetalkamat sheetalkamat requested review from weswigham and removed request for amcasey August 30, 2022 23:25
@sheetalkamat sheetalkamat requested a review from amcasey August 30, 2022 23:25
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 30, 2022
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, aside from some commented-out code in the test.

I do worry that this means we'll now only match exports paths with exact case matches, even on case-insensitive systems, but weather that's OK or not I guess depends on node's behavior?

@sheetalkamat
Copy link
Member Author

I do worry that this means we'll now only match exports paths with exact case matches, even on case-insensitive systems, but weather that's OK or not I guess depends on node's behavior?

I will lookup some cases and try to get that as well since we have methods that handle casing to check if paths match that way using case without having to convert the path to canonical form

@sheetalkamat
Copy link
Member Author

@weswigham fixed other references where absolute path was used to check canonically

@sheetalkamat sheetalkamat requested a review from weswigham August 31, 2022 21:21
@andrewbranch andrewbranch added this to the TypeScript 4.8.3 milestone Aug 31, 2022
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 31, 2022

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.8 on this PR at 9076f4d. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #50576 for you.

@alecmev
Copy link

alecmev commented Sep 1, 2022

Thank you!

@JounQin
Copy link

JounQin commented Sep 12, 2022

4.8.3 and 4.9.0-dev.20220912 both do not work to me with tsc --noEmit.

https://github.com/un-ts/lib-boilerplate/runs/8301954091?check_suite_focus=true#step:6:37

@sheetalkamat
Copy link
Member Author

Looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forceConsistentCasingInFileNames: true and moduleResolution: Node16 break type reference directives on macOS if there are capital letters in the path
7 participants