-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Do not canonicalize the file names when getting absolute paths during nodenext resolution #50557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, aside from some commented-out code in the test.
I do worry that this means we'll now only match exports paths with exact case matches, even on case-insensitive systems, but weather that's OK or not I guess depends on node's behavior?
src/testRunner/unittests/tscWatch/forceConsistentCasingInFileNames.ts
Outdated
Show resolved
Hide resolved
I will lookup some cases and try to get that as well since we have methods that handle casing to check if paths match that way using case without having to convert the path to canonical form |
@weswigham fixed other references where absolute path was used to check canonically |
@typescript-bot cherry-pick this to release-4.8 |
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
Hey @sheetalkamat, I've opened #50576 for you. |
Thank you! |
|
Looking into this |
Fixes #50544